Skip to content

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Sep 30, 2025

closes: #2219

feat: nv28 skeleton
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 07:32
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 30, 2025
@rjan90 rjan90 requested review from TippyFlitsUK and removed request for Copilot September 30, 2025 07:32
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting Review in FilOz Sep 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (c414105) to head (a79aceb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2220   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         147      147           
  Lines       15789    15789           
=======================================
  Hits        12250    12250           
  Misses       3539     3539           
Files with missing lines Coverage Δ
fvm/src/gas/price_list.rs 85.59% <ø> (ø)
fvm/src/machine/default.rs 69.47% <ø> (ø)
shared/src/version/mod.rs 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjan90
Copy link
Contributor Author

rjan90 commented Sep 30, 2025

For unblocking this PR/get past the #2221 failure in cargo-deny, I suggest to either:

  • Address it separately (i.e merge even with the failure) or update the deny.toml config to allow this temporarily.
  • Update wasmtime to a newer version (update wasmtime to at least 33.0.2 #2186) that doesn't use fxhash.
    • This might require significant changes.

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in FilOz Sep 30, 2025
@BigLep
Copy link
Member

BigLep commented Oct 3, 2025

Do you have a recommendation @rvagg ?

@rvagg
Copy link
Member

rvagg commented Oct 6, 2025

I'm fine with merging this as is, but also you could just update deny.toml in here since you've opened an issue for the problem already.

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 09:24
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a skeleton for network version 28 (nv28) by adding the necessary version constant and conditional compilation support. The changes prepare the codebase for future nv28 development while keeping it behind a feature flag.

  • Adds V28 network version constant alongside updating the comment for V27
  • Implements conditional compilation to support nv28 when the nv28-dev feature is enabled
  • Configures gas pricing for nv28 to use the existing TEEP_PRICES structure

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
shared/src/version/mod.rs Adds V28 constant and updates V27 comment from TBD to GoldenWeek
fvm/src/machine/default.rs Conditionally extends supported version range to include V28
fvm/src/gas/price_list.rs Adds V28 gas pricing support using existing TEEP_PRICES
fvm/Cargo.toml Introduces nv28-dev feature flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

chore: add RUSTSEC-2025-0057 to deny.toml
@rjan90 rjan90 merged commit 0d81399 into master Oct 6, 2025
17 checks passed
@rjan90 rjan90 deleted the phi/nv28-skeleton branch October 6, 2025 10:02
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Skeleton for nv28 to support development and testing

5 participants