-
Notifications
You must be signed in to change notification settings - Fork 146
feat: nv28 skeleton #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nv28 skeleton #2220
Conversation
feat: nv28 skeleton
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 147 147
Lines 15789 15789
=======================================
Hits 12250 12250
Misses 3539 3539
🚀 New features to boost your workflow:
|
For unblocking this PR/get past the #2221 failure in cargo-deny, I suggest to either:
|
Do you have a recommendation @rvagg ? |
I'm fine with merging this as is, but also you could just update deny.toml in here since you've opened an issue for the problem already. |
Co-authored-by: Rod Vagg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a skeleton for network version 28 (nv28) by adding the necessary version constant and conditional compilation support. The changes prepare the codebase for future nv28 development while keeping it behind a feature flag.
- Adds
V28
network version constant alongside updating the comment forV27
- Implements conditional compilation to support nv28 when the
nv28-dev
feature is enabled - Configures gas pricing for nv28 to use the existing TEEP_PRICES structure
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
shared/src/version/mod.rs | Adds V28 constant and updates V27 comment from TBD to GoldenWeek |
fvm/src/machine/default.rs | Conditionally extends supported version range to include V28 |
fvm/src/gas/price_list.rs | Adds V28 gas pricing support using existing TEEP_PRICES |
fvm/Cargo.toml | Introduces nv28-dev feature flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chore: add RUSTSEC-2025-0057 to deny.toml
closes: #2219